Giter VIP home page Giter VIP logo

Comments (9)

udoprog avatar udoprog commented on July 22, 2024

It seems like anything following the macro call gets munched, even if it's a comment or a use.

from rune.

tgolsson avatar tgolsson commented on July 22, 2024

Is there just a missing \n? Or more destructive?

from rune.

udoprog avatar udoprog commented on July 22, 2024

It chomps away all newlines (one per fmt call) until there's no separation at all between items.

from rune.

tgolsson avatar tgolsson commented on July 22, 2024

I think this invocation needs to add a newline:

if let Some(semi) = semi {
self.writer.write_spanned_raw(semi.span, false, false)?;
}

So true, false as the whitespace args. Super-busy at the moment but might have some time to look more in-depth during the weekend.

from rune.

udoprog avatar udoprog commented on July 22, 2024

No worries. Just thought you'd be interested! Take your time or if you want, I can look into it.

from rune.

tgolsson avatar tgolsson commented on July 22, 2024

Hmm, running locally I hit

error: Compile error
  ┌─ scripts/make_function.rn:3:5
  │
3 │     make_function!(inner_fn => { "Hello World Again!" });
  │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Missing macro `make_function`

on latest main.
Using the same command as CI; cargo run --bin rune -- fmt --experimental --recursive --verbose --workspace --check tools scripts

from rune.

tgolsson avatar tgolsson commented on July 22, 2024

Looks to be lookup order, though if I switch the import to the top it fails on the macro evaluation.

from rune.

udoprog avatar udoprog commented on July 22, 2024

Item expansion inside of functions has also* been temporarily disabled until I can figure out how to make it less messy. Try with the current version I just pushed.

I also have a pretty bad cold, so I might be checked out for a few more days.

from rune.

udoprog avatar udoprog commented on July 22, 2024

Closed in #539

from rune.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.