Bug when using replace_with after doing some node.decompose() operations about selectolax HOT 3 CLOSED

Is it reproducible when you parse different HTML files?

Selectolax uses Modest directly, when removing nodes:

I think your particular HTML file violates some of the standards and Modest can't process it properly.
If you have more example, please upload them too.

from selectolax.

I think the real problem is that your function can call decompose on already removed objects.
You can try using decompose(recursive=False).

Unfortunately, selectolax is a very thin wrapper over Modest and it does not check for such problems.
I think removing the same node multiple times corrupts memory.

You always need to keep in mind, that traverse iterates over all objects, and some of them could be already deleted or modified.
The nodes_to_remove array contains a parent and some of its children. When you use recursive decomposing, the child nodes get removed with the parent. On the next iteration, you are trying to remove the child object which does not exist anymore.

This is a common problem: lexbor/lexbor#132 (comment)

from selectolax.

Thank you, much clearer now!

from selectolax.