destroy method to remove all observation and disable about scrollama HOT 5 CLOSED

Hi!

scrollama.destroy() seems not to work anymore, undefined.
On the other hand scrollama.disable() and scrollama.enable() both work :

Any idea?

— G

from scrollama.

There is no return value on the function, so undefined is the correct return.

It should have removed all intersectionObserver listeners and not trigger any of the callback functions to update. Is that not happening?

from scrollama.

No, it doesn't remove my observers...

Using a basic setup and everything works like a charm, only this destroy method doesn't work.

from scrollama.

Ah so the callbacks are still firing? What browser/version are you using?

from scrollama.

Sorry, my mistake, scrollama.destroy() works!
I was fooled by the visual debugging tool which did not disappear when destroying (using PJAX) :

Maybe this one should be remove/reset too.

Thanks for your help!

from scrollama.