ZlibDecoder doesn't have any error checking about flate2-rs HOT 4 CLOSED

Do you have some example data that I could test out on? There should be quite a bit of error checking internally, but there may perhaps be a bug here or there.

from flate2-rs.

extern crate flate2;

use std::io::prelude::*;
use flate2::read::ZlibDecoder;

fn main() {
    let mut d = ZlibDecoder::new("test".as_bytes());
    let mut string = String::new();
    d.read_to_string(&mut string);
    println!("Here's the data {}",&string); //print's Here's the data + blank
}

Unlike GzDecoder, ZlibDecoder::new() doesn't return a result and just returns the encoder, so you don't know whether it actually decoded

from flate2-rs.

Ah this is actually because the error is being ignored in this example. If you println!("{:?}", foo) the result of the read_to_string call you'll see:

Err(Error { repr: Custom(Custom { kind: InvalidInput, error: StringError("corrupt deflate stream") }) })

And during compilation you should also being seeing:

src/main.rs:9:5: 9:35 warning: unused result which must be used, #[warn(unused_must_use)] on by default
src/main.rs:9     d.read_to_string(&mut string);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I'm gonna close this for now as it looks like the error is coming out ok, but let me know if you need any more help!

from flate2-rs.

Oh, thanks

from flate2-rs.