Giter VIP home page Giter VIP logo

Comments (3)

tgross35 avatar tgross35 commented on June 27, 2024

@rustbot label -needs-triage +C-feature-request +F-check-cfg +T-compiler

from rust.

Urgau avatar Urgau commented on June 27, 2024

That's an interesting idea, but I'm not sure how valuable it would be given the implementation challenges and the small number of potential users.

However regarding the "leads to noisy logs" part you can already significantly reduce the number of --check-cfg args by factorizing them by their values:

To avoid repeating the same set of values, use this form:

rustc --check-cfg 'cfg(name1, ..., nameN, values("value1", "value2", ... "valueN"))'

Which in your case would be something like: cfg(__ashldi3, __ashlsi3, __ashrdi3, ..., __aarch64_swp8_acq_rel, values("optimized-c")); this would already reduce significantly the number of arguments based on the logs you gave us.

One thing we should on our end, is using a dedicated argument file to pass all the --check-cfg arguments at once, rust-lang/cargo#13941.

from rust.

tgross35 avatar tgross35 commented on June 27, 2024

However regarding the "leads to noisy logs" part you can already significantly reduce the number of --check-cfg args by factorizing them by their values:

To avoid repeating the same set of values, use this form:
rustc --check-cfg 'cfg(name1, ..., nameN, values("value1", "value2", ... "valueN"))'

Which in your case would be something like: cfg(__ashldi3, __ashlsi3, __ashrdi3, ..., __aarch64_swp8_acq_rel, values("optimized-c")); this would already reduce significantly the number of arguments based on the logs you gave us.

I didn't know that was an option, thanks for the pointer.

One thing we should on our end, is using a dedicated argument file to pass all the --check-cfg arguments at once, rust-lang/cargo#13941.

That would be even better, and would solve the biggest problem I have here. With that open, I agree that regex probably wouldn't have many users.

from rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.