Giter VIP home page Giter VIP logo

Comments (5)

workingjubilee avatar workingjubilee commented on July 24, 2024

cc @erikdesjardins but also I think this was just an oversight.

from rust.

RalfJung avatar RalfJung commented on July 24, 2024

FWIW if one just adds this to a test it does pass on CI

//@revisions: csky
//@[csky] compile-flags: --target csky-unknown-linux-gnuabiv2
//@[csky] needs-llvm-components: csky

but of course it may just be silently ignored, hard to say whether the test actually runs... this needs-llvm-components stuff makes tests quite fragile. :/

from rust.

workingjubilee avatar workingjubilee commented on July 24, 2024

Yeah, the tidy check was added to reduce the fragility because a lot of people were giving names other than the LLVM component's name, like riscv64 instead of riscv, etc.

from rust.

RalfJung avatar RalfJung commented on July 24, 2024

The remaining question then is, how sure are we that the components accepted by tidy are all available on some CI runner?

from rust.

RalfJung avatar RalfJung commented on July 24, 2024

Also, something else must have been going on... I disabled this test before that sanity check was added to tidy.

Sadly the logs for this failure are already gone.

from rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.