Error code E0116 causes high volume of incorrect compiler errors about rust HOT 4 OPEN

I've never contributed to Rust OSS but if this may be first-time-contributor friendly, I'd be happy to give it a go. Any pointers of where to try changes beyond crate_inherent_impls would be appreciated!

from rust.

...huh, the impl Vec<usize> causes a failure to find .split on str...

from rust.

This happens because the query crate_inherent_impls returns a Result<&'tcx CrateInherentImpls, ErrorGuaranteed>, which means that when calling that query, if there's any error being propagated, we don't actually get the inherent impls. The options are to modify the existing query to never forward the errors (which would break the query caching mechanism, I believe) or add a second query that always succeeds, as a fallback to the fallible query so that we can get as many of the inherent impls as possible for the later resolutions.

from rust.

@anthonydandrea the most esoteric thing you'll have to deal with is the query system, as there's a function crate_inherent_impls with a corresponding query crate_inherent_impls which is a way of encoding the contract of the "providers", so that you can define whether calls should get memoized/cached on-disk. Because we want errors to be properly tracked, you'd have to add a new query that always succeeds that isn't cached, that only gets called if the other query call fails. You probably can put that logic behind a method in TyCtxt which deals with the fall back and then call that new method from everywhere the query gets called today.

from rust.