Comments (9)
All of this code looks pretty shitty and would like to use indicatif instead (#1835), but that'll have to wait for another day.
from rustup.
Suggestion: we should stick to the old format:
rustup/src/cli/download_tracker.rs
Lines 188 to 196 in 9caf4fc
... which means there should be an ETA: {}
somewhere.
My suggestion write!(f, " ETA: {}", self.0.display()),
in #3827 (comment) should do exactly this.
from rustup.
Why should we stick to the old format? I agree with #3826 that showing it after finishing is pointless.
from rustup.
Why should we stick to the old format? I agree with #3826 that showing it after finishing is pointless.
@djc Sorry, I meant stick to the old format when downloading. The expected result should be something like in 1s ETA: Unknown
.
from rustup.
For example if ETA is 3s, the current version will print in 1s3s
, which is clearly not ideal.
from rustup.
Ahh, no, I only applied half of your suggestion -- sorry, was too hasty; fix in #3829.
I was confused for a while by your screenshot showing "Unknown", but that seems unrelated.
from rustup.
Ahh, no, I only applied half of your suggestion -- sorry, was too hasty; fix in #3829.
I was confused for a while by your screenshot showing "Unknown", but that seems unrelated.
@djc Sorry, that Unknown
is caused by a division-by-zero I believe. I probably won't be able to make a better screenshot: it all goes too fast on my machine :]
from rustup.
All of this code looks pretty shitty and would like to use indicatif instead (#1835), but that'll have to wait for another day.
@djc I'm also in favor of using the console
suite (incl. dialoguer
and indicatif
). In #3803 however I tried my best not to introduce new dependencies 😅
from rustup.
Yeah, one step at a time. async -> tracing -> indicatif.
from rustup.
Related Issues (20)
- rustup fails to open non-existing windows registry path HOT 3
- `rustup component (add|remove)` should not rely on hardcoded target triples HOT 9
- Decide on a better strategy for release notes/changelogs HOT 3
- Simplify download and/or TLS backends HOT 1
- Rustup fails with os error 10054 on a new Windows 11 machine HOT 13
- `sh.rustup.rs` should only resolve to ipv4 HOT 7
- rust-analyzer is not being automatically proxied after installing HOT 4
- Rust installing script incompatible with older macOS HOT 1
- rustup should use the configured profile as fallback when the key is not present in `rust-toolchain.toml` HOT 5
- CfT: Test out Rustup's `reqwest` backend with `rustls` HOT 5
- error: toolchain 'stable-x86_64-pc-windows-msvc' is not installable with rustup 1.27.0 on wine HOT 4
- Failures while downloading https://static.rust-lang.org/rustup/dist/x86_64-unknown-linux-gnu/rustup-init HOT 1
- `rustup update self` should suggest `rustup self update` HOT 8
- Windows: Explorer 'Quick Access' polluted with deleted folders inside `.rustup`
- Lack of support for p521 signatures with the `ring`-based `reqwest/rustls` backend HOT 15
- New env `RUSTUP_AUTO_SELF_UPDATE` to configure `rustup self update` HOT 12
- (🐞) rustup didn't install Visual Studio HOT 7
- Disable Rustup's self update by default if the `CI` environment variable is detected HOT 3
- Effects of `RUSTUP_WINDOWS_PATH_ADD_BIN` change HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rustup.