Giter VIP home page Giter VIP logo

Comments (5)

rami3l avatar rami3l commented on August 17, 2024 1

Implementation-wise a basic idea would be placing an implicit.txt in the toolchain directory to signify that one toolchain is implicitly installed as required by one or more projects, with one toolchain file path per line.

If the file is missing or is empty, we consider the toolchain to be manually installed.

Finally, a toolchain can be pruned if it's implicitly installed and all paths in its implicit.txt are invalid. Otherwise, only the invalid paths are removed instead.

PS: This is neither saying I'm implementing it, nor meaning it's going to be implemented this way.

from rustup.

lolbinarycat avatar lolbinarycat commented on August 17, 2024 1

Finally, a toolchain can be pruned if it's implicitly installed and all paths in its implicit.txt are invalid. Otherwise, only the invalid paths are removed instead.

you would need to actually parse the rust-toolchain files, since it might have changed to reference a different toolchain (this is extremely common for things like clippy)

from rustup.

rami3l avatar rami3l commented on August 17, 2024

@lolbinarycat Thanks for filing this issue! I think this feature request is quite valid.

Indeed, you'd like to have something like this as well especially when you're working with many different projects each with its own rust-toolchain.toml (although I first encountered this with our downstream elan).

However since this is doesn't look like a trivial change, correctly implementing this might require some more investigation... Please bear with us as t-rustup's current bandwidth is still quite limited 🙇

from rustup.

djc avatar djc commented on August 17, 2024

Yeah, I'm honestly not sure the implementation complexity of this is worth it. At the very least (a) I don't think it should be a priority for us and (b) this needs a good design to decide where this state gets stored.

from rustup.

rami3l avatar rami3l commented on August 17, 2024

Yeah, I'm honestly not sure the implementation complexity of this is worth it. At the very least (a) I don't think it should be a priority for us and (b) this needs a good design to decide where this state gets stored.

Just to add some context: I installed Lean 4 with rustup-derived elan. When I was maintaining a project that relied on mathlib4, the latter included a toolchain file. As I bumped it from time to time, the toolchain file also got updated, so I ended up with more and more versioned installations of the toolchain without a way to "prune" them... I imagine the same thing will happen with Rust projects as well.

from rustup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.