Change lint crate loading. about marker HOT 5 CLOSED

I've done some research on the topic. The current way is definitely unstable and since the type layout can change between compilation I'm surprised that it has been working without a problem so far. ^^ I believe this issue is critical, as it might affect how we can represent information for lints.

I'll create an issue for this in the design repo, as we might get some more feedback there and do some experimenting with this.

from marker.

Looking into this, I feel like creating a general plugin system for Rust could be a rust-foundation grant all in itself. 😅

from marker.

It certainly could be! Plugin systems are by no means easy.

from marker.

Yeah, I sadly see no good way, without a stable ABI. One option could be to introduce a stable ABI similar to #[repr(C)] which allows support for rust types. This should be fine when it's not the default. On the other hand, I'm far from an expert, and c/c++ has some problems that come from the chosen ABI so 🤷.

from marker.

With the lint crate api rework of #34 and #35 I believe that we can close this issue. The linter will for now use dynamic libraries. I also heard an interesting idea to potentially add static linking for static and performance focussed implementations. This is still a good idea, but I feel like that would require a discussion in the /design repo.

Problems with the FFI interface will be tracked in a new issue 🙃

from marker.