Add consistent way of initializing custom event kinds about nostr HOT 5 CLOSED

Maybe the best way is to impl Eq and PartialEq manually checking if the u64 kind number is equal.
In this way Kind::Custom(20100) will be equal to Kind::Ephemeral(20100).
What do you think?

from nostr.

Something like:

impl PartialEq<Kind> for Kind {
    fn eq(&self, other: &Kind) -> bool {
        self.as_u64() == other.as_u64()
    }
}

from nostr.

Sounds promising.

from nostr.

Now I have the doubt to have misunderstood what you mean.
Have I?

I don't think that can be enforced the use of Kind::from(...).

Using the solution that I applied, if someone used Kind::Custom instead Kind::Ephemeral everything works (I added ephemeral kind not long ago). In this way it's backwards compatible.

from nostr.

Tested the new version, works! Thanks.

You're right, your idea with PartialEq is even better than enforcing Kind::from(...). Especially cause it's backwards compatible.

from nostr.