WebExtensions alarms about gloo HOT 3 OPEN

@Pauan I updated the proposal with your suggestions.

from gloo.

pub fn new(millis: u32, callback: F) -> Alarm

This needs to accept f64, since Date cannot fit into a u32 (even the current date is far beyond u32).

pub fn forget(mut self) -> String { .. }

I think it would be better if it returned an AlarmId, which would then have a cancel method.

I know that's not what gloo-timers does, but personally I think gloo-timers would benefit from that as well. Hiding implementation details seems like a good idea.

PeriodicAlarm

I think this should be renamed to RecurringAlarm

pub fn new<F>(minutes: u32, callback: F) -> PeriodicAlarm

I'm not sure (I need to test it), but I think it allows for partial minutes, like 1.5, so this should take f64.

Also, sometimes it's useful to specify both when and periodInMinutes, so we should have support for that, possibly through a new method.

from gloo.

Should we actually use types like std::time::{Instant, Duration} and then convert internally?

I think it would be better if it returned an AlarmId, which would then have a cancel method.

I like this a lot.

I think this should be renamed to RecurringAlarm

👍

Also, sometimes it's useful to specify both when and periodInMinutes, so we should have support for that, possibly through a new method.

This got me thinking, should we come up with more descriptive names for the constructors than just new, (combined with above idea) something like:

Alarm::schedule_at(Instant::now().add(Duration::of_secs(10)))

from gloo.