Giter VIP home page Giter VIP logo

Comments (4)

jcdyer avatar jcdyer commented on June 12, 2024 1

My preference would be to stick with acks_late=false for two reasons:

  1. It's consistent with the way python does it, so less surprising for people converting projects from python.
  2. It's an even better default in rust than in python, because error cases are generally marked, either statically by the Result or conventionally by documentation indicating which functions might panic, which makes it even easier to write code that won't crash unexpectedly.

Counter argument to my own point: We're still in the realm of networking, and unrecoverable errors (like pulled network cables, power outages, sharks, tornadoes, and wars) can always happen.

from rusty-celery.

alekhrycaiko avatar alekhrycaiko commented on June 12, 2024

Is this still a relevant task/issue?

Based on the docs you're linking it sounds like this should be default as False, unless tasks are generally idempotent.

from rusty-celery.

epwalsh avatar epwalsh commented on June 12, 2024

It's still relevant, but is just meant to be a discussion.

Python Celery has acks_late=false as the default, but I personally feel that true should be the default in Rusty Celery, as this is much safer (provided your tasks are idempotent).

I'd like to hear other opinions though.

from rusty-celery.

epwalsh avatar epwalsh commented on June 12, 2024

Thanks @jcdyer, those are good points. I think we will leave the default as false for the foreseeable future. And I'm actually going to close this issue now as having this open makes it seem like the default is true (I think it was initially, but at some point I changed it).

from rusty-celery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.