Giter VIP home page Giter VIP logo

Comments (9)

mpapis avatar mpapis commented on June 30, 2024 1

are you saying environment is not respected in this role? that would be a bug :)

from rvm1-ansible.

nickjj avatar nickjj commented on June 30, 2024

@rngadam What are you proposing, to have the rvm role write out the ~/.curlrc based on the value you provide to the variable or just a rvm1_http_proxy variable which you can set and use in your custom tasks instead of the curlrc?

from rvm1-ansible.

mpapis avatar mpapis commented on June 30, 2024

it has been a month without feedback - closing the issue - please let us know if you can provide the requested details and we will reopen

from rvm1-ansible.

rngadam avatar rngadam commented on June 30, 2024

Sorry, it's because I worked around it myself. I ended up creating a curlrc.j2 with the following content:

{% if host_proxy %}
proxy = {{host_proxy}}
{% endif %}

...and setting up as appropriate in my group_vars:

host_proxy: http://10.0.2.2:3128/

it seems a bit hacky?

from rvm1-ansible.

mpapis avatar mpapis commented on June 30, 2024

what's the status of this issue?

from rvm1-ansible.

nickjj avatar nickjj commented on June 30, 2024

Writing out a curlrc like this seems a little out of scope for the role unless I'm missing something? What do you think @mpapis?

from rvm1-ansible.

mpapis avatar mpapis commented on June 30, 2024

indeed, it should be up to the admin to set up proxies, a separate role to setup proxies could be an option - still out of scope - closing this.

from rvm1-ansible.

mrooney avatar mrooney commented on June 30, 2024

I agree that writing a curlrc is out of scope, but I would argue that proxy support in general is not. The relevant tasks should simply allow passing like an environment like we do for everything else: environment: '{{ proxy_env }}'. How about an rvm1_environment? Because there are various ones to set besides http_proxy including CURL_CA_BUNDLE if your org has their own certificate.

The main argument for this would be 1) users of rvm1 shouldn't have to know specific implementation details, like which tools are used to download, and configure them each specifically via a curlrc, and 2) any other tasks we write ourselves work fine with environment, there's no need to provision a curlrc for anything but rvm1 in our case anyway.

What do you think?

from rvm1-ansible.

mrooney avatar mrooney commented on June 30, 2024

@mpapis as far as I understood it, and last I tried, setting environment at the role level is not supported. That is, I cannot do roles: { role: rvm_io.rvm1-ruby, environment: '{{ my_env }}' } Is that wrong or is there another way I can be providing an environment to rvm1?

from rvm1-ansible.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.