Swift 4 support about action HOT 12 CLOSED

@fpillet I've tried your PR and it works very well for me now.

@fpillet Thank you very much for your help.

Thank you @ashfurrow.
This is really excellent piece of abstraction so thank you all working this.

Regards
Leszek

from action.

No worries, I'll take a look 👍 In the mean time, everything works with the podfile I posted above.

from action.

Hi there! I don't think anyone's tested this for Swift 4 yet (I know I haven't). The solution doesn't appear obvious, I'll try to take a look this weekend and get back to you.

from action.

I'm working on a Swift 4 PR. Coming right up.

from action.

BTW @leszarna I'm not sure your problem comes from Action itself. Would be nice if you could try and repro once we make the swift4.0 branch available.

from action.

Hi guys, I'm newbie with cocoapods and things like that :)
Xcode 9 is stable now so we have Swift 4 officially released. I updated my RxSwift and RxCocoa to use swift4.0 branch, but how can I do it with Action?
When I start pod install I got errors like this:

pod install
Analyzing dependencies
[!] Unable to satisfy the following requirements:

- `RxSwift (from `https://github.com/ReactiveX/RxSwift.git`, branch `swift4.0`)` required by `Podfile`
- `RxSwift (= 4.0.0-beta.0)` required by `Podfile.lock`
- `RxSwift (~> 4.0.0-beta.0)` required by `RxCocoa (4.0.0-beta.0)`
- `RxSwift (~> 4.0.0-alpha.0)` required by `RxDataSources (2.0.0-alpha.0)`
- `RxSwift (~> 2.0.0-beta)` required by `Action (0.1.0)`

from action.

Hi @adamsmaka – I'd be happy to help with this. Can you post your Podfile? Or at least the relevant portions of it? It looks like we might need to updated RxDataSources's podspec to point to the new beta: https://github.com/RxSwiftCommunity/RxDataSources/blob/swift4.0/RxDataSources.podspec#L44

from action.

of course, here it is

  pod 'RxSwift', git: 'https://github.com/ReactiveX/RxSwift.git', branch: 'swift4.0'
  pod 'RxCocoa', git: 'https://github.com/ReactiveX/RxSwift.git', branch: 'swift4.0'
  pod 'RxDataSources', git: 'https://github.com/RxSwiftCommunity/RxDataSources.git', branch: 'swift4.0'
  pod 'Action'

btw i love your framework veeeery much 😀😍

from action.

Thanks! I've reproduced the issue and I think it's caused by Action's pre-release not being on CocoaPods trunk. We should probably put Action up on trunk – my machine's setup is... not working right now for Swift 4 😞 @fpillet could you push the current podspec to trunk?

In the mean time, @adamsmaka , you can use Action's pre-release podspec with the following:

  pod 'Action', git: 'https://github.com/RxSwiftCommunity/Action.git', branch: 'master'

I had some issues with the branch names in your pod file, but was able to get CocoaPods working with the following:

  pod 'RxSwift', git: 'https://github.com/ReactiveX/RxSwift.git', branch: 'rxswift4.0-swift4.0'
  pod 'RxCocoa', git: 'https://github.com/ReactiveX/RxSwift.git', branch: 'rxswift4.0-swift4.0'
  pod 'RxDataSources', git: 'https://github.com/RxSwiftCommunity/RxDataSources.git', branch: 'swift4.0'
  pod 'Action', git: 'https://github.com/RxSwiftCommunity/Action.git', branch: 'master'

from action.

I'm currently on travel, in crunch mode and away from my usual Mac so not possible for me before next monday unfortunately

from action.

ok so we are waiting...

from action.

This is already fixed in #106

from action.