Comments (7)
Yup, gotcha. That's tricky – I think you're right that the struct is getting copied and the address used by objc_get/setAssociatedObject
. Hmm. We may have to remove support for non-reference-types. This was introduced in this pr. I think adding a : class
constraint to the HasDisposeBag
protocol should fix the issue (while removing the ability to use this on value types).
What do you think? Up for a pull request? Thanks again for opening the issue!
from nsobject-rx.
Right now I'm doing some more investigation, I'll update when I'm done but I think that's the issue.
from nsobject-rx.
Cool, thanks! Let us know what you find 👍
from nsobject-rx.
Ok, I did quite an investigation.
- I removed this pod completely and made sure there is no
rx.disposeBag
in my code - Replaced
rx.disposeBag
byself.disposeBag
But still, I'm seeing that issue. Which means I can't blame this pod for memory leaking.
However, I think that need to be fixed. I'll try to put a PR soon.
from nsobject-rx.
Awesome, I look forward to it 👍
from nsobject-rx.
PR is up! Discuss and comment there.
Thanks
from nsobject-rx.
Closed by #48, and released to CocoaPods as 4.0.0. Thanks again!
from nsobject-rx.
Related Issues (20)
- I got a problem HOT 1
- Swift 3 2.0.0 CocoaPods release? HOT 2
- New release? HOT 2
- Update podspec
- Problems at release a new version at CocoaPods HOT 2
- Allowing set on disposeBag HOT 7
- Support for RxSwift 4.0 HOT 3
- Switch CI to Circle
- Carthage support HOT 1
- Move to CircleCI 2.0
- swift 5 adapter HOT 3
- Remove Carthage from Circle CI build
- Build project in CI for other platforms not only iOS
- iOS Crash, memory management error HOT 1
- NSObject-Rx version 5.0.0 released? HOT 5
- SwiftPM support HOT 3
- Can't compile with Cocopods and Xcode 12 HOT 2
- why i can't use rx.disposeBag, just rx_disposeBag HOT 2
- Release new version HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nsobject-rx.