`dismissed` observable triggered without view being dismissed about rxflow HOT 4 CLOSED

I opened a pull request to resolve that issue: #27

It's not only a problem for alerts. The dismiss method of UIViewController behaves quite strange. Calling it in a view controller with a presentedViewController causes it to dismiss that view controller, but if there is none it dismisses itself.

from rxflow.

Hi @grafele
Thanks for your feedback. I've just merge your PR, great job.
Do you have a precise idea of why my original code was not working ? I don't understand why the "dismiss" method was called as it was only the Alert that was dismissed, not the root ViewController.

from rxflow.

Hi @twittemb ! I think the AlertViewControllers buttons don't call the dismiss function on the AlertViewController but on it's presentingViewController. That leads to the exact same effect: The alert will be dismissed, but it triggered also the old 'dismissed' observable, because it listened on the dismiss method call on the view controller itself.

The documentation on apple side actually helps:

The presenting view controller is responsible for dismissing the view controller it presented. If you call this method on the presented view controller itself, UIKit asks the presenting view controller to handle the dismissal.

from rxflow.

Thanks for this explanation. It makes sense.

I close this issue as it has been resolved.

Thanks again, and feel free to contribute again ! help is always welcome.

from rxflow.