Giter VIP home page Giter VIP logo

Comments (4)

ryandrewjohnson avatar ryandrewjohnson commented on May 18, 2024 1

I have updated the translate function to return a string when a translation does not include HTML. In the case where a translation contains HTML it will still return the translation wrapped in a <span> tag like it did previously.

I have also updated the README for getTranslate to explain this.

I chose this route instead of adding an option because:

  1. Keeps the API the same - no changes needed
  2. In order to render HTML contained in translations it has to be wrapped in a React element anyway.

You can find the changes in v2.3.0.

from react-localize-redux.

ryandrewjohnson avatar ryandrewjohnson commented on May 18, 2024

In order to allow for the rendering of HTML inside translation strings it needs to be returned as an element. I will look into maybe only returning an element when HTML is detected in the translation, and for other scenarios it would just return a string.

Would that satisfy your ask?

from react-localize-redux.

ieow avatar ieow commented on May 18, 2024

Actually, if there is an option for me to choose String type would be good enough.
I am now using LocalizedElement.props.children which is not a good solution.

from react-localize-redux.

ieow avatar ieow commented on May 18, 2024

Cool. Thanks. Tested. :)

from react-localize-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.