Giter VIP home page Giter VIP logo

Comments (7)

Finii avatar Finii commented on June 9, 2024 1

Ah here, it seems to be intended

1fe5837 FontAwesome: Scale glyphs a bit bigger

Which is part of

Lets compare the glyphs

You see, a lot glyphs got smaller on v3.1.1 -> v3.2.0 and grew back to a comparable size on v3.2.1.

For some other glyphs they stayed the same from v3.1.1 to v3.2.0 and now only grew with v3.2.1. But they usually also changed the outline (i.e. look different anyhow).

I don't know. The icons all changed with the substantial update from FA 4.7 (2016) to FA 6.5.1 (2024). The relative to each other sizes changed. It is hard to know what is now 'right'. In total the FA of our v3.2.0 was a bit on the small size (got reported) - not for all but for a lot icons. That was the reason to lift the size a bit.

Do you think the icons are now too big?
Sizewise I would look at v3.1.1 and v3.2.1, as v3.2.0 just lived 2 weeks or so.

image

from nerd-fonts.

martinpelikan avatar martinpelikan commented on June 9, 2024 1

Thank you for the very quick investigation and detailed response!

Do you think the icons are now too big?

From the perspective of my tiny use case, yes, but possibly because I grew used to the previous size. I'm not sure I would notice had they not overflowed the fixed size I had configured, something I can easily change.

I think I prefer the previous size because the line weight/thickness appears consistent with other symbols I use, but I haven't compared against many others. I wouldn't push for further changes if others are happy with where things are at.

Here's a comparison of the versions you mentioned:

3.1.1 3.2.1
2024-04-19_00-44 2024-04-19_00-45

from nerd-fonts.

Finii avatar Finii commented on June 9, 2024 1

the zeros?

🤦‍♀️

Yes. Thanks! 😺

from nerd-fonts.

Finii avatar Finii commented on June 9, 2024

A lot glyphs changed size, but why? 😬 😆

image

from nerd-fonts.

treequin avatar treequin commented on June 9, 2024

Also speaking from my personal use case, I find the increase in size makes FA icons difficult to integrate with icons from other sets.

I use U+F015 (nf-fa-home) with U+E725 (nf-dev-git_branch) for my prompt, and U+F057 (nf-fa-times_circle) and U+F05A (nf-fa-info_circle) with U+F0028 (nf-md-alert_circle) and U+F02D7 (nf-md-help_circle) for diagnostics. A before-and-after comparison:

3.1.1 3.2.1
branch-old branch-new
diagnostics-old diagnostics-new

Personally, I preferred the old size, but if the change was necessary I can switch to icons from other sets without problem.

from nerd-fonts.

Finii avatar Finii commented on June 9, 2024

@treequin What are these secondary circles in the bottom picture? They are not important I guess?

I guess this needs are more systematic approach 😬 Thanks for the input.

from nerd-fonts.

treequin avatar treequin commented on June 9, 2024

@treequin What are these secondary circles in the bottom picture? They are not important I guess?

I'm not sure I understand, do you mean the zeros? They're just the number of diagnostics of each type in the document (I took the screenshot on an empty file).

from nerd-fonts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.