Comments (8)
The code in question is taking advantage of the fact that implode will call __toString() on any object it encounters (which is needed for all CSSValues, not just CSSSize). Unfortunately, older versions of PHP (pre-5.2) do not support this. I’m not sure whether to work around this or to mark it wontfix and set PHP 5.2 as the minimum requirement for this library.
from php-css-parser.
I have fixed the issue by looping through the array and calling __toString if the element is an object, using the string if it is not, and adding commas accordingly. I can send you a diff if you would like.
I also added a few methods of my own to CSSDocument that returns a style as a string instead of the entire rule.
from php-css-parser.
I would be very interested in those changes you made to the CSSDocument. Just fork my repository and push your changes.
from php-css-parser.
I think I have committed my changes. I am a noob @ both git and github, so please let me know either way if you can or cannot see my changes or if I did it incorrectly.
from php-css-parser.
You need to use the “git push” command to push changes that you’ve checked in to the github repository.
from php-css-parser.
Ok. Done.
from php-css-parser.
I’ve commented on your commits. Please send a pull request after having worked through them so I can merge your changes.
from php-css-parser.
I think we’re dropping PHP pre-5.2 so I’ll close this.
from php-css-parser.
Related Issues (20)
- Strict parsing mode exception with whitespace-only CSS
- @media block gives syntax error HOT 2
- issue with var on multiline HOT 1
- Selectors inside :not() not correctly parsed HOT 2
- Add a Dependabot configuration HOT 1
- @layer support
- GitHub releases page not up to date with tags (missing 8.4.0) HOT 1
- Update the GitHub runners to the latest Ubuntu LTS version HOT 1
- Add tests with SimonSapin/css-parsing-tests HOT 1
- Expressions are not being parsed HOT 3
- How to get comment HOT 1
- Fix undefined `$oRule` in `DeclarationBlock`
- Fix undefined `$oVal` in `CalcFunction`
- Add proper setters and getters to `OutputFormat`
- Make all `in_array` call strict
- Fix the `Size` constructor arguments in `DeclarationBlock`
- Can't composer update on Linux Ubuntu corrupt error HOT 6
- Allow rgb(R G B / A) notation
- Is there a way to render block wrapper with @media
- Add support for new viewport unit in Size class
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-css-parser.