Giter VIP home page Giter VIP logo

Comments (3)

sabberworm avatar sabberworm commented on May 17, 2024 1

IMHO named colors should be parsed into rgb colors with an additional flag. On output, these could be rendered to names again using a reverse-lookup table.
Also, we should add format options on whether to prefer outputting colors the way they were input, or as hex, as function, or as named (if possible).

from php-css-parser.

JakeQZ avatar JakeQZ commented on May 17, 2024

Looking at the class hierarchy, Color extends CSSFunction extends ValueList extends Value. But a named colour would be neither a CSSFunction nor a ValueList - though would be a Color. Not sure how best to reconcile this. In #353 I suggested the possibility of a Keyword/Identifier type that could represent a any sort of named value, including a named color and a border-style, with the non-specific type simply wrapping a string (of unknown meaning). Something to think about...

from php-css-parser.

JakeQZ avatar JakeQZ commented on May 17, 2024

Not sure how best to reconcile this.

Maybe the named colour class type would need to be quite separate in the class inheritance hierarchy, focusing more on how it is parsed than what it actually represents. If there's a need to provide common functionality between named colours and RGB colours, an interface could be provided, which both implement. That interface might be Color, with the existing Color being renamed to RgbColor.

These are just thoughts that might help with the design for this change.

from php-css-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.