Giter VIP home page Giter VIP logo

Comments (5)

Fbartoli avatar Fbartoli commented on June 10, 2024 1

don't care if EOA is actually a valid owner and

Why bother with the feature then? You can generate a random private key and sign the message

The author doesn't care but in my use-case this is essential and an huge UX improvement.
I do need signature from ALL safe account signees

from safe-apps-sdk.

Fbartoli avatar Fbartoli commented on June 10, 2024

I agree this would big an huge UI UX improvement for our use case.
Looking at the code they interact with the safe account using https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage

Maybe it wouldn't be too much of a hassle to use that feature to request the safe web app to interact with the EOA wallet on behalf of the Iframe.

from safe-apps-sdk.

mmv08 avatar mmv08 commented on June 10, 2024

don't care if EOA is actually a valid owner and

Why bother with the feature then? You can generate a random private key and sign the message

from safe-apps-sdk.

ubinatus avatar ubinatus commented on June 10, 2024

don't care if EOA is actually a valid owner and

Why bother with the feature then? You can generate a random private key and sign the message

Hi @mmv08. The purpose of the feature (back then) was to allow the Safe App to consume the wallet client (the connected wallet on the app.safe.global website). As mentioned on the description, one of the intended use cases was to be able to use the wallet client to sign a message mainly for authentication purposes within the developer's DApp.

I take back this part: i) don't care if EOA is actually a valid owner (just updated the description). Just wanted to be able to let the connected user sign a message without the need to interact with SignMessageLib (no need for all multisig owners to approve it).

from safe-apps-sdk.

mmv08 avatar mmv08 commented on June 10, 2024

ii) takes time to wait for all owners to approve the message and execute the Gnosis Safe: Sign Message Library and you won't like to wait that whole process just for interacting with the DApp.

Just FYI you can use offchain signatures which should be faster: https://docs.safe.global/safe-smart-account/signatures/eip-1271

from safe-apps-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.