Giter VIP home page Giter VIP logo

Comments (6)

nijikokun avatar nijikokun commented on June 4, 2024

It doesn't matter as you can ascertain this anyway if you have unique username during registration. Security through obscurity never works out well.

from passport-local-mongoose.

caffeinewriter avatar caffeinewriter commented on June 4, 2024

Even still, it's another hurdle for potential attackers to overcome before actually ascertaining if a username does exist.

from passport-local-mongoose.

nijikokun avatar nijikokun commented on June 4, 2024

Attackers don't attempt login first, they check whether they are registered, then they do the brute forcing. The easiest way of doing this? Registering as the user, or checking a public profile page, or api request with the username if you're doing a username based attack, some apis provide email lookup. Aside from this the other way attackers gather access is to get the database itself but that's another can of worms.

So not really seeing where this hurdle is.

from passport-local-mongoose.

caffeinewriter avatar caffeinewriter commented on June 4, 2024

Fair enough, but as a general rule of thumb, it's a good idea to follow OWASP recommendations.

from passport-local-mongoose.

nijikokun avatar nijikokun commented on June 4, 2024

I have no idea why OWASP never responds to discussions... but here is this note anyway - https://www.owasp.org/index.php/Talk:Authentication_Cheat_Sheet#Correct_Response_Example

from passport-local-mongoose.

saintedlama avatar saintedlama commented on June 4, 2024

My intent was not that these error messages would be displayed to the user. In the next version of passport-local-mongoose these errors and error messages will get refactored to make it hard for developers using passport-local-mongoose to divulge authentication error details.

from passport-local-mongoose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.