Comments (6)
It doesn't matter as you can ascertain this anyway if you have unique username during registration. Security through obscurity never works out well.
from passport-local-mongoose.
Even still, it's another hurdle for potential attackers to overcome before actually ascertaining if a username does exist.
from passport-local-mongoose.
Attackers don't attempt login first, they check whether they are registered, then they do the brute forcing. The easiest way of doing this? Registering as the user, or checking a public profile page, or api request with the username if you're doing a username based attack, some apis provide email lookup. Aside from this the other way attackers gather access is to get the database itself but that's another can of worms.
So not really seeing where this hurdle is.
from passport-local-mongoose.
Fair enough, but as a general rule of thumb, it's a good idea to follow OWASP recommendations.
from passport-local-mongoose.
I have no idea why OWASP never responds to discussions... but here is this note anyway - https://www.owasp.org/index.php/Talk:Authentication_Cheat_Sheet#Correct_Response_Example
from passport-local-mongoose.
My intent was not that these error messages would be displayed to the user. In the next version of passport-local-mongoose these errors and error messages will get refactored to make it hard for developers using passport-local-mongoose to divulge authentication error details.
from passport-local-mongoose.
Related Issues (20)
- cant find methods User.createStrategy() User.serializeUser() User.deserializeUser()
- Unique email (with unique username) HOT 2
- Calling authenticate() against an existing instance is looking up a different user to check the password HOT 4
- why change user.id two times?
- Generic type 'Query<ResultType, DocType, THelpers>' requires between 2 and 3 type arguments. HOT 1
- Type issues with SerializeUser
- Include type definitions directly in the package HOT 2
- Login fails if the "username" field contains "+" character HOT 1
- The problem occurs when deploying two or more completely different apps (not two instances of the same app).
- Salt and hash field can be updated manually
- options.usernameQueryFields needs to be set to default empty array HOT 3
- Unauthorized plain text HOT 4
- usernameField settings outlined in the docs do not work HOT 4
- Usernamequeryfields not inspected on calling register function
- How to pass errors on register method to the front-end HOT 1
- Mongoose 7 does not support some callbacks like in 6.x version and it cause exceptions in passport-local-mongoose HOT 1
- TypeError: teacherSchema.plugin is not a function
- TypeError: user.get is not a function
- [MissingUsernameError] No username was given HOT 1
- TypeError: Cannot read properties of null (reading 'name')
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from passport-local-mongoose.