Comments (6)
Both ways work but being consistent would definitely look more "pretty". At least the end result is still the same.
from design-system.
I plan to spent some time digging in sources to know how things done. It wouldn't hard to me to make a pr with coonsistent imports.
from design-system.
What do you say on my proposal? Should I do it?
from design-system.
Hi @Guria! Sure, why not!
In general, it should be pretty simple. A couple of things:
- We've been importing globals as
g
now,import g from 'app_modules/global';
- The prefixer we've been aliasing
import { perfix as pf }
:)
Any help is awesome! Thanks!
from design-system.
How would you recommend:
- 1 file per 1 commit per 1 pr
- 1 file per 1 commit, several commits in 1 pr
- collect as much as I can into 1 commit / 1 pr
- another scheme
from design-system.
1 commit in 1 PR with all changes to all files would be best. :)
from design-system.
Related Issues (20)
- Bug: Accordion component SASS fails to compile with Angular HOT 12
- [suggestion] Register your namespace "slds" HOT 1
- Line height tokens HOT 1
- slds-theme-warning doesn't display the icon with inverse variant HOT 1
- Unable to sign in for CLA HOT 1
- [DOC] Wrong icon color example
- [Button] Dual Button color not visible
- [DOC] Broken hyperlinks on Visualforce page
- Module Not Found Issue HOT 2
- docs: Brand Back background images are broken
- TreeGrid accessibility support
- button and button-icon not horizontally aligned correctly HOT 5
- NPM Error HOT 1
- Unable to download the libraries using the Sketch Plugin HOT 1
- Version 2.21.2 (spring-23) contains a blob as readme and breaks all builds HOT 4
- Different styling with disabled states between inputs and text area HOT 1
- Incorrect order of css vars in text area HOT 1
- No styling hooks for different parts of the datatable
- Nexus conflit with @salesforcedx/design-system HOT 1
- Bullet points with <ul> tag HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from design-system.