Giter VIP home page Giter VIP logo

Comments (6)

amyleesalesforce avatar amyleesalesforce commented on May 21, 2024

Both ways work but being consistent would definitely look more "pretty". At least the end result is still the same.

from design-system.

Guria avatar Guria commented on May 21, 2024

I plan to spent some time digging in sources to know how things done. It wouldn't hard to me to make a pr with coonsistent imports.

from design-system.

Guria avatar Guria commented on May 21, 2024

What do you say on my proposal? Should I do it?

from design-system.

amyleesalesforce avatar amyleesalesforce commented on May 21, 2024

Hi @Guria! Sure, why not!

In general, it should be pretty simple. A couple of things:

  • We've been importing globals as g now, import g from 'app_modules/global';
  • The prefixer we've been aliasing import { perfix as pf } :)

Any help is awesome! Thanks!

from design-system.

Guria avatar Guria commented on May 21, 2024

How would you recommend:

  • 1 file per 1 commit per 1 pr
  • 1 file per 1 commit, several commits in 1 pr
  • collect as much as I can into 1 commit / 1 pr
  • another scheme

from design-system.

amyleesalesforce avatar amyleesalesforce commented on May 21, 2024

1 commit in 1 PR with all changes to all files would be best. :)

from design-system.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.