Comments (4)
@diervo I have added some tests to validate that this is actually fixed.
from lwc.
@diervo can you clarify? the code in question is:
getAttribute(attrName: string): string | null {
// logging errors for experimental and special attributes
if (process.env.NODE_ENV !== 'production') {
const vm = this[ViewModelReflection];
assert.vm(vm);
if (isString(attrName)) {
const propName = getPropNameFromAttrName(attrName);
const info = getGlobalHTMLPropertiesInfo();
if (info[propName] && info[propName].attribute) {
const { error, experimental } = info[propName];
if (error) {
assert.logError(error);
} else if (experimental) {
assert.logError(`Attribute \`${attrName}\` is an experimental attribute that is not standardized or supported by all browsers. Property "${propName}" and attribute "${attrName}" are ignored.`);
}
}
}
}
return getAttribute.apply(getLinkedElement(this), ArraySlice.call(arguments));
}
the check that you're questioning is only in dev mode and only cares about well-known attributes/properties. dataId
is an unknown property, therefore no error will be issued, and the last line of the method, which is the real important part, is still doing the job. This is on master today. Maybe this issue is not relevant any more.
from lwc.
@diervo pls provide more details
from lwc.
closed by #468
from lwc.
Related Issues (20)
- Inherited template not found when using TypeScript and Babel HOT 3
- Rendering component with API version 60 lazily inside an element without `lwc:dom=manual` does not invoke `connectedCallback` or render in dev mode
- Synthetic lifecycle observable changes when slotted into native lifecycle
- Allow ElementInternals/FACE without native custom element lifecycle
- Allow components to opt in to native custom element lifecycle
- SSR hydration mismatch errors in `class` attributes HOT 1
- A synthetic shadow component can observe that its slot container is native shadow
- Hydration validation incorrectly fails for statically optimized content HOT 3
- Expand static content optimization HOT 2
- List re-rendering causes DOM state to be lost HOT 1
- Type definition for `createElement` is inaccurate
- Remove temporary support for v7 compiler + v6 engine
- Synthetic custom element lifecycle swallows DOM errors for `insertBefore` HOT 1
- Multiple Off-Platform LWC's on one page HOT 9
- array mutations are not reactive in a custom lightning-datatable component. HOT 2
- Add Karma fuzz-testing for mixed API version components HOT 1
- `disableSyntheticShadowSupport` should allow `<slot>`s to be static-optimized
- Remove `validationOptOut` for manual opt-outs of hydration mismatch validation HOT 1
- Upgrade to prettier v3
- Log warning for host mutation during SSR HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lwc.