Merged URL not valid about saloon HOT 4 CLOSED

Sorry for lots of comments! To be honest, I think a "DoNotIncludeTrailingSlash" would do the trick because that's the only thing that you can't control at the moment with how Saloon builds URLs. If I added that trait - you would be responsible to add the trailing slash but you could do the rest in the request endpoint.

from saloon.

Thanks for submitting this issue, really glad you like Saloon! This definitely sounds like a bit of a bug. Where I intended to always only have one trailing slash, it adds another. I believe a fix for this would be to not add any leading slash if it doesn’t exist already, but if one exists already - leave it in there.

If you are happy to submit a PR for this, that would be great - if not I’ll try and add it in later today after work.

from saloon.

Actually thinking about this more - if I remove the logic that fixes trailing/leading slashes - it will become a breaking change as people will assume Saloon will fix their leading/trailing slashes (a problem that I have had before)

Maybe Saloon could introduce a new trait like “DoNotIncludeTrailingSlash” or something?

Alternatively, I can remove the logic where I add a trailing slash in the ManagesGuzzle file in the base url. This would cause people’s APIs to break unless they put a leading slash in the request.

I could also introduce Request interceptors which modify the Saloon request before it is sent to Guzzle.

Another idea would be to introduce a new way to be able to overwrite how Saloon builds up the URL. Maybe there could be a defineUrlBuilder($baseUrl, $requestUrl)

I think that combined with request interceptors would really make Saloon powerful.

from saloon.

This should now be fixed in v0.3.1. I've made it so if you set the endpoint in your request to be an empty string, Saloon won't append the trailing slash. Thanks for submitting this issue!

from saloon.