Accept error and bool with Must() about lo HOT 6 CLOSED

P.S: Just out of curiosity, why is each test case wrapped into separate blocks? I'd probably place them into individual t.Runs instead and give more context via the description. It's probably just a question of preference, but I'm curios anyway

I copied and modified the existing TestMustX code. There is no other intention.

from lo.

I tried this

And

How about MustOK(Parse(""))?

from lo.

MustOK is good!

from lo.

No need, just allow any instead of error. You throw away compile time type matching for runtime assertion. It's not a problem because people who will use Must() expect their code to panic at this point anyway.

from lo.

No need, just allow any instead of error. You throw away compile time type matching for runtime assertion. It's not a problem because people who will use Must() expect their code to panic at this point anyway.

I didn't think that far. Check out my PR. Must* panics when err is error or false. I deleted condition err != nil. Is it okay to ignore cases that err is neither error nor bool?

from lo.

Your PR looks good :) thank your for your support on this 💯

P.S: Just out of curiosity, why is each test case wrapped into separate blocks? I'd probably place them into individual t.Runs instead and give more context via the description. It's probably just a question of preference, but I'm curios anyway

from lo.