Giter VIP home page Giter VIP logo

Comments (3)

Vaelzan avatar Vaelzan commented on June 29, 2024

More info for the second of the two bugs, so you don't need to go run the command I mentioned yourself:

Example of how your placed feature JSON ends up: https://pastebin.com/aAXZHLk0
Same thing in vanilla Minecraft: https://github.com/misode/vanilla-worldgen/blob/master/worldgen/placed_feature/rooted_azalea_tree.json

A JSON export of your placement should ideally end up pretty much identical to the one in vanilla, but with "feature": "ecologics:rooted_azalea_tree", in the top line. The other features are all impacted too, I just used the azalea as an example since it was easy to refer to the vanilla version. I haven't verified that it's the use of Holder.direct, but glancing at the code makes that seem like the likely culprit (vanilla uses Holder.hackyErase in the register method inside PlacementUtils instead, despite the scary looking name).

Edit: This is happening in the configured features too, here:

public static final ConfiguredFeature<RootSystemConfiguration, ?> ROOTED_AZALEA_TREE = new ConfiguredFeature<>(Feature.ROOT_SYSTEM, new RootSystemConfiguration(PlacementUtils.inlinePlaced(Holder.direct(ModConfiguredFeatures.AZALEA_TREE)), 3, 3, BlockTags.AZALEA_ROOT_REPLACEABLE, BlockStateProvider.simple(Blocks.ROOTED_DIRT), 20, 100, 3, 2, BlockStateProvider.simple(Blocks.HANGING_ROOTS), 20, 2, BlockPredicate.allOf(BlockPredicate.anyOf(BlockPredicate.matchesBlocks(List.of(Blocks.AIR, Blocks.CAVE_AIR, Blocks.VOID_AIR, Blocks.WATER)), BlockPredicate.matchesTag(BlockTags.LEAVES), BlockPredicate.matchesTag(BlockTags.REPLACEABLE_PLANTS)), BlockPredicate.matchesTag(BlockTags.AZALEA_GROWS_ON, Direction.DOWN.getNormal()))));
- it's copying the azalea_tree configured feature into the rooted_azalea_tree configured feature, instead of a reference to it.

from ecologics.

samedifferent avatar samedifferent commented on June 29, 2024

I appreciate the comprehensiveness. I'll put out a fix later today.

from ecologics.

samedifferent avatar samedifferent commented on June 29, 2024

Fixed https://www.curseforge.com/minecraft/mc-mods/ecologics/files/3737616

from ecologics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.