Support Ecto Repo about rihanna HOT 9 CLOSED

It could be specified via mix config, as with the other configuration in Rihanna.

By default it continues to behave as it does today, however this config could be specified like so:

# A named postgrex connection is used
config :rihanna,
  enqueue_postgres_connection: {Postgrex, :my_postgrex_connection}

# An Ecto connection pool is used
config :rihanna,
  enqueue_postgres_connection: {Ecto, My.Repo}

In either of the above cases the Rihanna.Job.Postgrex process is not started.

from rihanna.

Interesting idea. From what I understand, this is only for the process that enqueues jobs, is that correct?

from rihanna.

What do you mean? :)

from rihanna.

I mean, it's for Rihanna.enqueue - not the dispatcher?

from rihanna.

Yes, it's only for enqueuing.

Ecto doesn't offer a way to always request the same connection from the pool so the dispatcher so the advisory locks wouldn't work. I believe it is possible to check out a connection long term with Ecto, but this is effectively the same as having a dedicated Postgrex connection so I'm not sure I see an advantage.

from rihanna.

This seems like a good idea. Feel free to implement :)

from rihanna.

Do you like the config design above?

from rihanna.

Yeah it looks ok.

from rihanna.

It could be passed at runtime for sure.

I suggested that API because Rihanna doesn't currently accept configuration beyond the Postgrex config at runtime so I thought that would be more in keeping with the current API.

from rihanna.