Comments (2)
I believe there's 3 instance of logging in the server: failed to connect to server, failed to set previous watches, and a catch all for unexpected errors (which likely point to bigger issues).
One alternative is to turn off logging and use exported metrics so that any existing alerting infrastructure can be used (e.g. failed to connect N times in M seconds).. this likely should be added anyway regardless of logging.
Do you think it would be ok if you could pass in a custom logger to the client (func (c *Conn) SetLogger(Logger)
) conforming to an interface like:
type Logger interface {
Printf(format string, v ...interface{})
}
and by default the stdlib log
would be used. Then could override it to disable logging entirely or reroute to a more appropriate place (perhaps syslog if using it).
from go-zookeeper.
I think that would make sense to me. Then have an unexported struct field for the Logger. To avoid breaking the old way, we could default to setting up a logger that has the same behavior as now.
from go-zookeeper.
Related Issues (20)
- cannot connect ZooKeeper 3.4.6.2.5
- Can not get event channel from the channel returned by Connect
- How Connect Zk Cluster HOT 1
- Set timeouts now occur after error check
- Support Go Mod? HOT 2
- Zookeeper clients contending for distributed lock get into deadlock state during network partition failure
- Conn AddAuth not working? HOT 3
- client cannot work when a server node in the cluster died HOT 1
- Exists api return true but path does not exist HOT 3
- DeleteRecursive(path string)
- Delete node(s) fails to delete without any error
- zookeeper node garbled code
- Is this project active? HOT 1
- why EventNodeDataChanged trigger children watch?
- can you release a version? HOT 1
- GSSAPI SASL authentication
- Why clear timeout when read a response from server? HOT 1
- Please make an issue menu in go-zk/zk repository, and archive this. HOT 1
- data race in conn.go
- How about archiving this repository?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-zookeeper.