Giter VIP home page Giter VIP logo

Comments (5)

mperego avatar mperego commented on August 17, 2024 1

Fixed bug in Enthalpy test 20c896
Now test result is independent of workset size. As I expected the bug was very specific of an evaluator exclusively used by the Enthalpy solver.

I'm closing this issue an refer to #49 for the ATO part.

from albany.

ibaned avatar ibaned commented on August 17, 2024

#49 is part of this

from albany.

mperego avatar mperego commented on August 17, 2024

I'm pretty confident that the issue in commit 9116dba is not related to #48 or #49. I think it has to do with an evaluator that is only used in the Enthalpy test, and that I will fix when I'll go back working on that capability. That's why I did not open an issue.

from albany.

ibaned avatar ibaned commented on August 17, 2024

true, they are likely unrelated multiple bugs.

from albany.

mperego avatar mperego commented on August 17, 2024

Your guess on the issue being related to the "last" workset makes sense to me. I will check that. My first guess for the Enthalpy test, is that I'm doing a (tricky) integral along a vertical column, and that I might be wrongly assuming that all the cells in a column belong to the same workset, although that's not guaranteed and it depends anyway on the workset size. Anyway, I'm glad that the change in the workset size exposed this serious bug. I'm not that worried because this is a new/experimental capability that has not been used yet for real applications.

from albany.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.