Comments (8)
Hi Brian,
My initial reaction is that we should pursue option (2) above. The features in these models that are causing issues were added in our effort to move towards kokkos compatibility. It seems like we could create a flag based on known compiler versions.
I don't like the fact that you have to comment out code to get things to compile.
Any other thoughts @lxmota ?
from albany.
Yes, I agree that the preferred option is (2).
from albany.
Brian, as per our conversation today, go ahead and take a stab at providing an internal flag and appropriate code guards. Please let me know if you encounter any issues.
from albany.
Hi Jake. This commit
https://github.com/bgranzow/Albany/commit/a852c9d3398de7cc6a10bf9006e60ef9601aa78c
on my fork of Albany seems to have resolved the issues for me, while not adversely affecting normal Albany builds.
Specifying -D DISABLE_LAMBDAS=ON in the Albany config script optionally disables the three models which were problematic with the gcc 4.7.2. compiler. The variable defaults to OFF and should maintain the previous behavior by default.
This is a pretty easy fix to apply, but it might make the upcoming merges we discussed more difficult than they need to be. My plan is to hold off applying these changes until those merges are complete. Sound reasonable?
from albany.
Hi Brian, looks good to me, and what you suggest sounds reasonable. When the upcoming kokkos related merges occur in the LCM source, we can test and hopefully close this issue.
from albany.
@bgranzow says w.r.t. 3a53f55:
Unfortunately, these changes did not resolve the error associated with #9 when I compiled at this ocmmit 64558eb.
My guess is this has more to do with how ParallelConstitutiveModel<...>::computeStateParallel(...)
is implemented, not really how it was instantiated.
from albany.
@bgranzow here is another attempted fix for you to try: efa6968. Its in the dont_capture_this
branch. Since the compiler bug has to do with a lambda capturing the this
pointer, I tried to avoid doing that.
from albany.
The 'dont_capture_this' branch compiles without any warnings, and is more correct than the workarounds I suggested. I'm closing this issue.
Thanks @ibaned!
from albany.
Related Issues (20)
- Nightly test failures HOT 39
- corePDEs_SideSetLaplacian_3D failing on weaver after epetra removal HOT 6
- Clean up nightlies to turn off Epetra HOT 4
- PyAlbany MatrixOperations test failing in spack nightly HOT 18
- Attaway sems modules are broken, causing those tests to fail
- Failing PyAlbany test in spack nightly build HOT 4
- Failing nightly builds due to Omegah HOT 2
- Rework nightlies on CEE for new RHEL8 OS HOT 1
- Can not finish albany spack install since trilinos failed to be installed HOT 6
- Failing attaway nightlies due to Netcdf/Pnetcdf HOT 28
- Weaver failing nightlies HOT 10
- Failing landIce_FO_GIS_AdjointSensitivity_Thickness test in nightly spack build HOT 12
- Failing corePDEs_SteadyHeatConstrainedOpt2D_Conductivity_Dist_Param_Restart test in some nightlies HOT 3
- Failing corePDEs_SideSetLaplacian_3D in CUDA weaver build HOT 2
- Failing landIce_FO_MMS_FO tests on some platforms HOT 8
- Failing corePDEs_SideSetLaplacian_3D test in weaver build HOT 2
- Get CEE clang builds back up on cee-compute001 and cee-compute005
- CALI build failure in nightlies HOT 3
- landIce_FO_GIS_AdjointSensitivity_Thickness failing again on several platforms HOT 6
- New milestone or Version after 200 closed issues since 2020 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from albany.