Giter VIP home page Giter VIP logo

Comments (7)

sandreas avatar sandreas commented on May 30, 2024

but the merge command does support mp3 output

I have tried several variations, including defining output format, codec, --no-convert, --mark-chapters, etc. It appears that the tagging step is just skipped if the output format is mp3

Yes, with the release 0.3.3 mp3 tagging is not supported yet, but I'm working on it. I did some research but i did not find a possibility to create an mp3 with chapters (http://id3.org/id3v2-chapters-1.0) with ffmpeg or native PHP (e.g. https://github.com/JamesHeinrich/getID3, i will add an issue for mp3 chapter frame addendum soon).

Since m4b-tool already has a lot of dependencies (ffmpeg, mp4v2 and optionally fdkaac) i would only add a new dependency if it replaces an old one.

Here is the specification of id3-Chapters, perhaps there is something in native PHP that i could use:
http://id3.org/id3v2-chapters-1.0

Here is a nightly build with at least tagging support over ffmpeg (no chapters!), but it may break some other things since i have not tested everything.

m4b-tool nightly build

Just give me feedback if you find an issue...

A list of planned features that are already included:

  • Batch merging with multiple patterns (to merge more than one audio book at once, based on directory names for tags)
  • Sort title support (for series that are not sorted alphabetically like harry potter)
  • Tagging for mp3
  • Many other minor fixes and code improvements

from m4b-tool.

gubler avatar gubler commented on May 30, 2024

It looks like you can add chapters using ffmpeg directly, but I can only find an example using a metadata file and from what I can see in your code, you are writing all of the metadata via command line arguments (according to AbstractConversionCommand. The linked article references an mp4 file, but I dumped the metadata from a podcast episode with chapters and got a similar format (I have attached the metadata file).

metadata.txt

I guess if the output file was an mp3 you could dump the metadata to a file (along with any chapter information) and then add the proper command line arguments to import it. I understand that would be a pain to do, however.

I've forked the repo and if you don't get to it before I do, I'll see if I can figure out how to do that myself. However, it will be a month or more before I can really dig into the code (April is a very busy month for me).

Thanks for the awesome tool!

from m4b-tool.

sandreas avatar sandreas commented on May 30, 2024

Ok, I'll take a look at it. It would be very helpful if you could provide a command line sample, what you really executed (sample files are not needed)... e.g.:

m4b-tool merge my-mp3-files --output-file=output.mp3

from m4b-tool.

sandreas avatar sandreas commented on May 30, 2024

Ok, should be fixed. Well not only fixed, but also improved. MP3-Chapters might be supported (like in podcasts), but this is experimental and not verified totally for all files. Additionally, Sort-Order Names and Descriptions should be supported, too.

Unfortunately there is no way to preselect the "media type" as audiobook in iTunes for mp3 files. It seems that this attribute is not stored in the mp3 file itself, but in the iTunes media library database after changing the type of a file. See https://community.mp3tag.de/t/permanently-change-mediatype-for-itunes/13895/5 for reference.

Heres a nightly for testing, if you would like to: m4b-tool.zip (nightly)

Feedback is welcome.

from m4b-tool.

gubler avatar gubler commented on May 30, 2024

I will test this early next week - I won't have a chance until then.

But thank you very much for implementing this.

As far as I know, you are correct that there is no "Audiobook" tag for MP3s that iTunes will acknowledge.

from m4b-tool.

gubler avatar gubler commented on May 30, 2024

Sorry for the delay - I finally got to test this today and it is working as expected for mp3 files and chapter data.

from m4b-tool.

sandreas avatar sandreas commented on May 30, 2024

Nice to hear that, thank you for you feedback. Since you are the only one who reported this, i will not make a release version only for this, because i'm refactoring the code to make it more maintainable first. Other nice features are coming ;)

from m4b-tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.