Giter VIP home page Giter VIP logo

Comments (5)

sandreas avatar sandreas commented on May 30, 2024

Does this result in stopping the merge? In my opinion it just should be a hint, that there is not cover available in the file.

If you do not want to use covers, you could use --skip-cover...

from m4b-tool.

gennaios avatar gennaios commented on May 30, 2024

The merge completes. I haven't test listened to them yet but peeked at the chapters text file and all looks fine. A hint indeed is preferable though perhaps it might be more elegant to be silent w/o any warning or info.

from m4b-tool.

sandreas avatar sandreas commented on May 30, 2024

The problem is, that i cannot tell for every file type, if an error occured or if the file just does not contain a cover (i did not find an ffmpeg option to check for existing coverart without extracting it...).
The best compromise in my opinion was to show a warning (not an error), if --skip-cover is not provided. I also think that it is good practice, to show a warning, if something is wrong or missing, that should be there - even when it is not a real error that results in a damaged file...
I'm afraid, there is no better solution than the current behaviour at the moment...

If your merge is working and there is no other problem, i would close this bug due to external limitations... ok?

from m4b-tool.

gennaios avatar gennaios commented on May 30, 2024

Merge is working fine. I think I was previously using --skip-cover though from not having used m4b-tool in a while, I picked a command from my command history. You can indeed close the issue. Thank you.

from m4b-tool.

sandreas avatar sandreas commented on May 30, 2024

You're welcome :-)

from m4b-tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.