Giter VIP home page Giter VIP logo

Comments (2)

SaneMethod avatar SaneMethod commented on June 21, 2024

Good catch, although I have to admit to some curiosity as to what circumstances might lead a developer to disable browser-level caching, but enable caching in local storage.

In any case, it looks like your proposed regex is a bit too specific - it assumes the _ parameter that jQuery appends will appear as the first parameter, which is not necessarily the case. Let's instead use the same regex that jQuery uses to detect the presence of the _ param:

/([?&])_=[^&]*/

If you'd like to make a pull request with the relevant change, I'll review and merge it.

from jquery-ajax-localstorage-cache.

softwarespot avatar softwarespot commented on June 21, 2024

Thanks for the regex tip. I managed to locate it in ajax.js for those wondering where you found it. The capture group isn't not really needed, but I guess we should be consistent with jQuery's version.

from jquery-ajax-localstorage-cache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.