Giter VIP home page Giter VIP logo

Comments (2)

0xlakshay avatar 0xlakshay commented on May 27, 2024

Other than this maybe we can modify the behaviour of sanic.request.parameters.RequestParameters but I am not completely sure about this.
I think sanic.request.parameters.RequestParameters already tries to achieve something similar but it doesn't work here while validation the query dict with models. Also should we modify its behaviour validation usecase also needs discussion.

RequestParameters
class RequestParameters(dict):
    """Hosts a dict with lists as values where get returns the first value of the list and getlist returns the whole shebang""" 

    def get(self, name: str, default: Optional[Any] = None) -> Optional[Any]:
        """Return the first value, either the default or actual
        ...
        """
        return super().get(name, [default])[0] <---- talking about this

    def getlist(
        self, name: str, default: Optional[Any] = None
    ) -> Optional[Any]:
        """Return the entire list
        ...
        """
        return super().get(name, default)

Can I raise a PR with FIx 1 or 2? For now we have to resort to a custom query validator decorator which is not fun.

from sanic-ext.

0xlakshay avatar 0xlakshay commented on May 27, 2024

Oops! found this #157, much cleaner solution
Seems to be working fine in latest version! closing this

from sanic-ext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.