`BadRequest: Not Found` when processing the installation deletion about octomachinery HOT 5 CLOSED

So staring at this more I noticed the following:

1. This is called by an HTTP 404 response from GitHub API
2. The call seems to have been for retrieving the installation metadata
3. There are mentions of @bmillemathias and @fao89 on the Sentry event page
4. The event might be uninstall

from octomachinery.

This is likely the bit of payload that would explain things:

GidgetHubWebhookEvent(name='installation', payload={'action': 'deleted', 'installation': {'id': 11811136, 'account': {'login': 'bmillemathias', 'id': 8579,

My latest theory is that @bmillemathias removed the app installation during the bot's startup from the user account, but I'm not sure what's the usual API response because of GitHub's eventual consistency.

Although, this would explain the non-existing install if the App is trying to get the data of a just-deleted installation. This would mean a problem in octomachinery and not patchback.

from octomachinery.

Aha! So it seems like 94e7765#diff-dfc12ecf149560867a2fea1a08ae6d29dbe742b16d964aec485cb5cfb392c2a6R133-R134 needs to be extended here https://github.com/sanitizers/octomachinery/blob/3ce9e19/octomachinery/github/api/app_client.py#L111 so that https://github.com/sanitizers/octomachinery/blob/3ce9e19/octomachinery/routing/webhooks_dispatcher.py#L60 actually works.

from octomachinery.

Transferring this to the octomachinery repo now.

from octomachinery.

Turns out, an issue for this already exists at #34.

from octomachinery.