Typegen: Can't generate types with conditional values in slice and ordering operations even when the it doesn't effect the type. about sanity HOT 3 CLOSED

No problem at all!

You are running into a similar problem, but with a different expression. It's not the type generator, but how we utilize babel to traverse your code and piece together the different javascript expressions to find the "final" query. I think we could add support for binary expressions as long as both sides resolves to a literal value. However, I don't think this is the case for you here? I assume you're using this to paginate? You could instead of using javascript parameter use groq parameters? https://www.sanity.io/docs/groq-parameters#

We also have a guide for doing more efficient pagination here, but it depends on your use case 🙂

from sanity.

Hi!

This is not a bug in typegen per se, but rather how we discover queries. Since your query references a variable that contains a conditional expression we are unable to determine it. We would need to create a matrix of different query node types, with your example it would be "easy" since both would be the same, but we would also need to handle cases where they weren't

I think in your case however, this should work:

const start = 0
const limit = start + 12

const order = `| order(_createdAt ${orderBy})`
const slice = `[${start}...${limit}]`

groq`*[_type == "document"]${order}${slice}`

from sanity.

Thanks for the response and the explanation, partly fixed the problem!

Ran into a different problem where TypeGen threw a BinaryExpression error, fixed it by first declaring the variable with a static value and then mutating it with the dynamic values.

let start = page;
start = (page - 1) * POST_PER_PAGE;

let limit = POST_PER_PAGE;
limit = POST_PER_PAGE + start;

Not sure if this is the intended behaviour or not, could be useful to have some docs around the various errors 😃 Completely understand that TypeGen is experimental feature, been really enjoying it so far!

from sanity.