Giter VIP home page Giter VIP logo

Comments (9)

santigarcor avatar santigarcor commented on May 23, 2024 1

Actually i think it's a good idea.

from laratrust.

santigarcor avatar santigarcor commented on May 23, 2024 1

@Naoray , Thanks but i already solved it with 934f260

from laratrust.

Naoray avatar Naoray commented on May 23, 2024

I tried it with:

// config
'middleware_handling' => 'abort',
'middleware_params' => '403',


// middleware
if ($this->auth->guest() || !$request->user()->ability($roles, $permissions, [ 'validate_all' => $validateAll ]))
{
    return call_user_func(Config::get('laratrust.middleware_handling'), Config::get('laratrust.middleware_params'));
}

... it works, but there are some errors in the tests:

1) LaratrustAbilityTest::testHandle_IsGuestWithNoAbility_ShouldAbort403
Mockery\Exception\NoMatchingExpectationException: No matching handler found for Mockery_9__config::get('laratrust.middleware_handling'). Either the method was unexpected or its arguments matched no expected argument list for this method

But I did not figure out how to resolve it yet. Any idea?

from laratrust.

santigarcor avatar santigarcor commented on May 23, 2024

@Naoray Indeed i'm working on it. I think the problem is the test.

from laratrust.

santigarcor avatar santigarcor commented on May 23, 2024

Could you please try it out, i got it working in 556515a. remember to add the middleware_handling and middleware_params to your config/laratrus.php file

from laratrust.

Naoray avatar Naoray commented on May 23, 2024

you've had a typo in the middlewares... fixed it in #24 . It works perfectly, but the tests are still failing!! :/

from laratrust.

santigarcor avatar santigarcor commented on May 23, 2024

@Naoray yeah i had the typo, maybe i did the typo in the tests too, i'm going to check it out

from laratrust.

santigarcor avatar santigarcor commented on May 23, 2024

@Naoray Yeah the problem was that the typo was on the tests too. i'm solving it now.

Thank you! 👍

from laratrust.

Naoray avatar Naoray commented on May 23, 2024

@santigarcor got them! fixed in #25

from laratrust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.