Giter VIP home page Giter VIP logo

Comments (3)

AhmedEissa123 avatar AhmedEissa123 commented on August 26, 2024

I found that my calculations were wrong so I’m closing this issue.

from empyrial.

AhmedEissa123 avatar AhmedEissa123 commented on August 26, 2024

So after some other calculations, I found that some of your code is wrong (I think).
So the problem with your code is it doesn’t account properly for changing weights over time.
Since, you multiply all the returns data in the get returns function by the same weights.
While actually as the price changes for assets in the portfolio weights also change.

from empyrial.

santoshlite avatar santoshlite commented on August 26, 2024

Fixed in v2.1.2 of Empyrial!

from empyrial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.