UIVeri5 uses old chromedriver version about ui5-uiveri5 HOT 14 CLOSED

Hi Tomas,
We recognized this problem last week, will provide a fix ASAP (till next week), meanwhile you could workaround it with a soft link to a chromedriver-2.46, this will disable the chromedriver download.

from ui5-uiveri5.

Hi, we delivered the fix we discussed here: https://github.com/SAP/ui5-uiveri5/releases/tag/v1.37.0

from ui5-uiveri5.

discussion/bug report: https://groups.google.com/forum/#!topic/chromedriver-users/8VmMaFjs1cg seems, that it might get resolved automatically "in a few month", but it seems that even chromedriver team is not consistent on it.

from ui5-uiveri5.

uff, they effectively disabled the "latest" mechanism as the chromedriver is now versioned for the browser and we could not simply download the highest version as it would be for chrome canary/beta/dev and could be incompatible with the commonly used chrome stable. Other browsers like Edge and Safari use similar version model but deliver the webdriver with the browsers so effectively you always have the correct version installed on the machine. The solution would need to be more complex. The problem is that I do not see a reliable way to download the respective webdriver automatically. Do you have idea how to handle this ?

from ui5-uiveri5.

@cvakiitho
Another workaround is to manually force a specific version of chromedriver as explained in the first chapter: https://github.com/SAP/ui5-uiveri5/blob/master/docs/config/drivers.md

from ui5-uiveri5.

Yeah I know, I tried to lobby against the change: https://groups.google.com/forum/#!topic/chromedriver-users/8VmMaFjs1cg

apart from having hardcoded latest version in this repo, I can think of only checking actual chrome version via --version from command line, but that's platform dependent.

I'll dig a bit more tomorrow.

Colleague recommended https://github.com/giggio/node-chromedriver , but they seem to have the same issue as we have now, maybe they'll fix it faster though.

from ui5-uiveri5.

I also was thinking of checking chrome version but the problem is starting chrome as this is platform specific e.g. we need to hardcode all the (non-trival) logic in our code. Another solution I am evaluating is having a source of truth in the form of a file in his repo. We will update it with the release version of the current stable version of chrome and uiveri5 will check on every start, instead of checking the chromedriver repo. We could even keep the versions per channel e.g. you configure the chrome channel you use and uiveri5 will update the chromedriver respectively.

from ui5-uiveri5.

well, least work would probably be, to just hardcode major version to this repo:
https://chromedriver.storage.googleapis.com/LATEST_RELEASE_74
instead of LATEST_RELEASE, as major version changes like once in ~3 months.

from ui5-uiveri5.

and then what, in 3 months you would need to update to a new uiveri5 version?. This is a nightmare, we have seen it first hand as many developers will miss understanding what is the problem and will write an issue/ticket/complain that our tool does not work.

from ui5-uiveri5.

Yeah I know, but we have three options anyway, hardcode the major version somewhere, check actual installed chrome version(best imo), or leave chromedriver installation to everyone, as every other testing framework is doing :)

from ui5-uiveri5.

Actually, I am thinking of a fourth option - hardcode in some central file and make uiveri5 check it on every start. This way you will get updates of chromedriver without a module update.

from ui5-uiveri5.

Yeah, that way we won't have to change anything apart from link to LATEST_RELEASE check. , I like it.

from ui5-uiveri5.

We can easily use gh-pages to generate LATEST_RELEASE url hosted by ghub:
#37

from ui5-uiveri5.

btw, latest chromedriver needs latest selenium webdriver standalone cvakiitho@291de44

from ui5-uiveri5.