Comments (4)
Hey @sappelhoff, I've been taking some time for myself and for other projects but I can definitely try to get #99 finished up in the next few days! Apart from other work, the issue is that an API-changing PR like that has a tendency to snowball as you encounter other issues and things to clean up, so I'm going to try breaking it down a bit to make things simpler/easier.
from pyprep.
Hi @sappelhoff !
Sorry I have not been much active. There has been quite a lot of work on my hands.
@yjmantilla will you manage to finish Compare RANSAC in pyprep and autoreject #36, and if yes, can you estimate when?
Tbh I have forgot about that. What I get reading the comments there is that the goal now is to have a documented example that compares both RANSAC's in an isolated way (that is, not as a part of PREP or Autoreject, but just as something that finds bad channels).
@a-hurst commented that
Yep, this definitely seems useful! I still need to read this PR over properly so it may have this already, but it would be great to have a section in the example that compares/contrasts the usage of PyPREP vs AutoReject (i.e., types of noise detection, full file vs per-epoch) so that understanding when/where to use each is clearer to newcomers (I remember getting confused by this myself last year when first setting up my EEG pipeline).
From this what I get is that whatever functionality that PR tried to do, it is already done on another. Thus I should focus myself on a documented example.
Now, originally it was only about RANSACs, but @a-hurst mentions a Pyprep Vs Autoreject comparison. For me that would be two different documented examples.
So, what is expected for 0.4 is a documented example of PyPrep RANSAC vs Autoreject RANSAC comparison (not the comparison of the whole packages). Is this correct?
Right now, I have a lot on my hands, I think I cannot promise something before October . I could advance here and there but for something guaranteed to be delivered I need my semester to finish first :/
from pyprep.
What I get reading the comments there is that the goal now is to have a documented example that compares both RANSAC's in an isolated way
Yes, I think that's what #36 could do ... just compare the pyprep and autoreject RANSAC implementations with each other.
So, what is expected for 0.4 is a documented example of PyPrep RANSAC vs Autoreject RANSAC comparison (not the comparison of the whole packages). Is this correct?
Yep
Right now, I have a lot on my hands, I think I cannot promise something before October . I could advance here and there but for something guaranteed to be delivered I need my semester to finish first :/
okay! :-)
from pyprep.
https://pypi.org/project/pyprep/0.4.0/ 🎉 as discussed in #105 (comment)
from pyprep.
Related Issues (20)
- Passing a custom montage to the PrepPipeline(raw, montage=?)? HOT 5
- Saving prep.raw give error " ValueError: Measurement infos are inconsistent for dig" HOT 4
- List of channel names causes TypeError in find_bad_by_ransac HOT 2
- migrate from `.zenodo.json` to `CITATION.cff` HOT 1
- update issue/pr templates HOT 1
- Computation of window size based on cutoff frequency in local detrend method HOT 1
- Question: using pyprep.NoisyChannels on numpy arrays HOT 1
- Issue with RawBrainVision HOT 2
- find_all_bads throws inf/nan error after filtering/detrending? HOT 12
- Documentation for Noisy Channels Algorithms' stand-alone use HOT 1
- [Feature suggestion] Allow for relevant annotation selection during processing. HOT 1
- How to include the prep output in my preprocessing pipeline? HOT 1
- New release? HOT 4
- Possible to add an argument in find_bad_by_nan_flat() to change FLAT_THRESHOLD ? HOT 2
- Add to NoisyChannel a bad_by_psd method to tackle low-frequency artefacts HOT 8
- add channels in raw.info['bads'] to unusable channels in Reference class HOT 5
- CI: Fixes needed for Numpy 2.0
- We should replace our own implementation of MAD by the one now available in scipy
- Move towards `np.random.default_rng`
- Move from `pick_types` to `inst.pick` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyprep.