EOG get dropped about pyprep HOT 4 CLOSED

Hey @christian-oreilly I didn't write that part of the code, but it's most likely for convenience, because only EEG channels are "corrected" in the PREP flow.

But there is certainly a way to keep the EOG channels part of raw and simply ignore them throughout the flow. A PR to achieve that would be welcome!

from pyprep.

I was thinking of this just yesterday. Probably at the end we could just add the missing channels. Alternatively the reference and rereference channel parameters that get into pyprep should be able to do the "ignoring" but im not sure of the current behavior down to the lowest level.

EDIT: just checked, in prep_pipeline the drop is done regardless of the the input ref and reref channel parameters.

So I guess the most straightforward way would be to make a copy of the non-eeg channels and then add them at the end. You guys agree?

from pyprep.

PR #34 would do it. I made it before seeing @yjmantilla comments so I will let you check if it does it how you want it to be done but I think it is well-aligned with the direction you were proposing,i.e., make a copy of the non-eeg channels and merge them back at the end... but I did not do it in the .raw object directly in case it can have side effect. I made it available through a property that add on the fly the missing channels to the .raw object and return a copy.

from pyprep.

I think the way you did it is nice. Hopefully after the formatting changes it should complete the tests successfully

from pyprep.