Giter VIP home page Giter VIP logo

Comments (5)

saqimtiaz avatar saqimtiaz commented on June 10, 2024

Improvements on the filter expression:

[[Unlike conventional online services, TiddlyWiki lets you choose where to keep your data, guaranteeing that in the decades to come you will still be able to use the notes you take today.]search-replace:g:regexp[(.{40}).*],[$1]search-replace:g:regexp[(.*)\s(\w+)$],[$1]]

or

[[Unlike conventional online services, TiddlyWiki lets you choose where to keep your data, guaranteeing that in the decades to come you will still be able to use the notes you take today.]search-replace:g:regexp[^(.{30,45})\s.*$],[$1]]

The latter is potentially more brittle if there is no word boundary between 30th and 45th character.

from streams.

saqimtiaz avatar saqimtiaz commented on June 10, 2024

Can also check for only whitespace in the text body and avoid the recursive macro while we are at it:


\whitespace trim
\define stream-show-breadcrumbs()
<$list filter="[<currentTiddler>has[stream-type]]">
	<$list filter="[<currentTiddler>get-stream-root:includeall[]]">
		<$wikify name="display-title" text={{{ [<currentTiddler>!is[binary]get[text]trim[]!is[blank]] ~[{!!title}] }}}>
			<span class="sq-breadcrumbs-fragment">
			<$link to=<<currentTiddler>>>
				<$text text={{{ [<display-title>split[]first[50]join[]] }}}/>
			</$link>>
			</span>
		</$wikify>
	</$list>
</$list>
\end
<$list filter="[{$:/config/sq/streams/enable-breadcrumbs}match[yes]]" variable="_NULL">
<<stream-show-breadcrumbs>>
</$list>

This does not include the above breadcrumb improvements. Also, use :reduce.

from streams.

zhangxiubo avatar zhangxiubo commented on June 10, 2024

One thing I have noted when tweaked this macro myself for improved readability was that just testing whether text field is blank can occasionally lead to a blank fragment when the wikified text field is "effectively" blank, e.g. when the tiddler only contains a image tag or some macros.

To circumvent the issue, I prepared a regex pattern that detects some common non-blank content. The breadcrumb shall only fall back to using the title field if the text field appears to contain effectively blank content:

<$set name="pattern" value="^\s*(\w|\[\[|`|''|//|__)">
  <$wikify name="display-title" text={{{ [<currentTiddler>!is[binary]regexp:text<pattern>get[text]] ~[{!!title}] }}}>
    <span class="sq-breadcrumbs-fragment">
    <$link to=<<currentTiddler>>>
      <$text text={{{ [<display-title>split[]first[50]join[]] }}}/>
    </$link>>
    </span>
  </$wikify>
</$set>

from streams.

saqimtiaz avatar saqimtiaz commented on June 10, 2024

@zhangxiubo thank you for the input, it is very helpful.

You have helped me to realize that there is a better way to check for blank fragments, since wikify will always return plain text. So we should check if the text is blank after we wikify. This will be more reliable and accurate than a regular expression.

Something like this (untested):


<$wikify name="display-title" text={{{ [<currentTiddler>!is[binary]get[text]trim[]] }}}>
	<span class="sq-breadcrumbs-fragment">
	<$link to=<<currentTiddler>>>
		<$text text={{{ [<display-title>!is[blank]else<currentTiddler>split[]first[50]join[]] }}}/>
	</$link>>
	</span>
</$wikify>

from streams.

zhangxiubo avatar zhangxiubo commented on June 10, 2024

@saqimtiaz That's definitely a better solution!

from streams.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.