warning Missing return type on function about frontend-starter-toolkit HOT 8 CLOSED

Alright quick run through on a fresh pull, npm run dev and npm run test are both working without any errors/warnings. Thanks for the help!

from frontend-starter-toolkit.

Nvm just pulled your latest update that fixed this! 95ac64a

from frontend-starter-toolkit.

@BlueAccords The error still exists in the test file, and I am still trying to get that to work. Having a discussion here: typescript-eslint/typescript-eslint#384

from frontend-starter-toolkit.

Oh ok, i'll keep an eye out for updates to the repo then. Do you think it'll cause any problems if I use your boilerplate as a base for development or will I run into issues if I try to write tests due to the same issue?

from frontend-starter-toolkit.

I will update this repo as soon as I get a response from someone there. Also, I am trying to convert this into a npm package so that you don't have to copy paste it and can just use npm versions to update the whole boilerplate.

from frontend-starter-toolkit.

The issue still has a workaround that you explicitly mention void as a return type on test functions, which can be a short term solution. Apart from that, I don't think it would break anything else.

from frontend-starter-toolkit.

Alright. Also with the latest version i'm getting this error when trying to run tests but i'm assuming this is the same one you're running into and trying to resolve .

> jest

 FAIL  src/App.test.tsx
  ● Test suite failed to run

    Cannot find module 'core-js/modules/es6.promise' from 'App.test.tsx'

      1 | import React from 'react';
      2 | import TestRenderer from 'react-test-renderer';
    > 3 | import App from './App';
        | ^
      4 |
      5 | it('renders without crashing', async () => {
      6 |   TestRenderer.create(<App />);

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at Object.<anonymous> (src/App.test.tsx:3:1)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        1.996s

from frontend-starter-toolkit.

@BlueAccords I updated the project, Could you take the latest change, remove the node modules and do a fresh install?

from frontend-starter-toolkit.