Comments (3)
kaelig
commented on June 8, 2024
Thanks for using sass-mq! The final resolution for this issue can be found here: #65 (comment)
from sass-mq.
seothemes
commented on June 8, 2024
Yes but also see https://adamwathan.me/dont-use-em-for-media-queries/
The tests in the blog post you referenced were incorrect, therefor pixels are still the best option.
Why not support both? Would you accept a PR?
from sass-mq.
kaelig
commented on June 8, 2024
The tests in the blog post you referenced were incorrect
How so? The author of https://zellwk.com/blog/media-query-units/ does mention Safari doesn't handle zoom + em media queries correctly and still comes to the conclusion that em-based media queries are the most sensible choice.
Edit: I see what you mean – his conclusions on px-based media query handling by Safari are misleading. However this doesn't change the fact that px-based media queries are bad for accessibility.
Sass MQ is an opinionated library that goes in the sense of enabling accessibility, not hindering it. Hopefully Safari fixes their implementation! There is a bug open here: https://bugs.webkit.org/show_bug.cgi?id=156687 – feel free to get in touch with the WebKit folks to try to get the work prioritized.
In the mean time, if you really need pixel-based media queries I'd encourage you to use this fork: https://github.com/flea89/sass-mq
from sass-mq.
Related Issues (20)
- It's just too long, I'd rather use @media instead HOT 1
- My company uses Sass MQ :) HOT 1
- Using sass-mq with webpack / create-react-app looks like broken HOT 2
- Breakpoints at wrong width HOT 2
- MQ EM issue HOT 3
- Function finished without @return HOT 3
- Empty mixin output when $mq-responsive is false can break extending placeholders HOT 1
- Would it be possible to support rem as units as well? HOT 1
- Creating a custom device specific breakpoint HOT 2
- Warning using / for division is deprecated HOT 12
- Redesign and update library HOT 11
- Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
- README fix in "Changing Media Type" section HOT 2
- When will v6.0.0 be out of beta HOT 1
- Invalid CSS error message HOT 2
- Error migration from @import to @use HOT 1
- Breakpoints showing up as 2x the width I specified HOT 1
- Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0 HOT 2
- My company uses Sass MQ HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sass-mq.