Comments (9)
no we shouldn't
from libsass-python.
So, you would rather your library not work with Py_DEBUG or are you telling me there is a better fix that you would like to implement?
from libsass-python.
it works fine for me -- please describe your actual use case instead of jumping to a solution
from libsass-python.
gcc -Wno-unused-result -Wsign-compare -g -Og -Wall -fPIC -DPy_LIMITED_API -I./libsass/include -I/usr/local/include/python3.8d -c _sass.c -o build/temp.linux-aarch64-cpython-38-pydebug/_sass.o -fPIC -std=gnu++0x -Wall -Wno-parentheses -Werror=switch -DLIBSASS_VERSION=\"3.6.5\"
cc1: warning: command-line option '-std=gnu++11' is valid for C++/ObjC++ but not for C
In file included from /usr/local/include/python3.8d/Python.h:88,
from _sass.c:1:
/usr/local/include/python3.8d/object.h:63:2: error: #error Py_LIMITED_API is incompatible with Py_DEBUG, Py_TRACE_REFS, and Py_REF_DEBUG
63 | #error Py_LIMITED_API is incompatible with Py_DEBUG, Py_TRACE_REFS, and Py_REF_DEBUG
| ^~~~~
/tmp/pip-build-env-h82wsj1h/overlay/lib/python3.8/site-packages/setuptools/config/setupcfg.py:520: SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use license_files instead.
warnings.warn(msg, warning_class)
error: command '/usr/bin/gcc' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for libsass
Failed to build libsass
ERROR: Could not build wheels for libsass, which is required to install pyproject.toml-based projects
from libsass-python.
please describe your actual use case
from libsass-python.
I moved to a debug version of python to debug some code by compiling with --with-pydebug. When I did, libsass failed to compile when I ran poetry install for my application with the error above. I am unable to run my application without it, which means I cannot do the debugging I need to do, which is blocking me from doing my job. I was able to fix this issue with the PR I submitted.
I am running the latest release of Python 3.8 on Alpine Linux.
from libsass-python.
you're free to fork 👍
this isn't a problem in python3.10+ so I don't want to carry code specifically for old pythons
from libsass-python.
There are still almost 2 years of support for Python 3.8 and another year past that for 3.9 and your library works with neither under pydebug, so it's disappointing that you are cutting off support for versions that are supported for a long time. Especially when it's a 4 line change (one being a comment). I've updated my change to look for versions now too, so it will work the way you want under 3.10 and will now work under pydebug under 3.9 and below, which will help folks who aren't bleeding edge (like most companies in the world), but it sounds as if that is not important to you.
# Py_LIMITED_API does not work for Py_DEBUG either in versions less than 3.10
if distutils.sysconfig.get_config_var('Py_DEBUG') == 1 and sys.version_info < (3,10):
py_limited_api = False
define_macros = []
from libsass-python.
it's not "just a 4 line change" -- you're introducing a deprecated library for a niche-at-best use case that we don't test and don't support. your attitude is not appreciated and additionally, neither you nor your company are sponsoring development
from libsass-python.
Related Issues (20)
- Add wheels for musl linux HOT 6
- Different behaviour when reading from filename vs string HOT 1
- Compiler does not remove `@use` rules HOT 1
- Typo in Changelog version HOT 3
- compile bulma sass? HOT 2
- error: invalid argument -std=gnu++<snip> not allowed with C HOT 12
- Bizarre incompatibility between googlecloudprofiler and libsass HOT 2
- Importers return errors with full tracebacks HOT 1
- How to use libsass with boussole through a single python process? HOT 1
- 0.22.0: documentation seems is not ready for sphinx 6.1.3
- ERROR: Could not build wheels for sass, which is required to install pyproject.toml-based projects` HOT 2
- How to use in toml based projects HOT 1
- Compile error when compiling Foundation SCSS witin Sanic Framework using sanic-sass HOT 1
- Unit tets faileurs: test_build_one, test_stack_trace_formatting HOT 2
- Support Python 3.12 HOT 1
- Release version with wheels for python > 3.7 HOT 2
- math loading errors with libsass 0.22.0 HOT 1
- Missing wheels for M1 macs, does not compile on macOS 13.4 HOT 4
- Is '@use' supported? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsass-python.