Giter VIP home page Giter VIP logo

Comments (5)

Saulis avatar Saulis commented on August 28, 2024

Hi!

First of all, thanks for the kind words 😄

The reason why I've left the default height of 400px is that iron-list seems to render quite poorly on the first pass when there isn't any explicit height set. So, it's in a way been a backup value, which can be overridden by the user.

But, I'll have a look if it's just enough to add a comment about that somewhere and use height: auto.

iron-list has this in their index.html:

Important: iron-list must either be explicitly sized, or delegate scrolling to an explicitly sized parent. By "explicitly sized", we mean it either has an explicit CSS height property set via a class or inline style, or else is sized by other layout means (e.g. the flex or fit classes).

I'll also try how it would work with iron-flex-layout so that I wouldn't need to set any explicit heights.

from iron-data-table.

Saulis avatar Saulis commented on August 28, 2024

Couldn't get it working properly without an explicit height on a parent, I'll add a note about this on the docs.

from iron-data-table.

jcrowthe avatar jcrowthe commented on August 28, 2024

I have managed to get the height to properly be set (while using 'height: auto') when I navigate to a page with iron-data-table on it. It is a small nuance, but it functions for what I need.

Thank you for looking into it though! I did too, but was unable to get it to work using iron-flex-layout or the generic CSS flexbox. Unfortunately, it may be something that iron-list needs to find a way to fix before it will work here.

from iron-data-table.

Saulis avatar Saulis commented on August 28, 2024

Hey, have a look at #17, and the branch feature/flex-height I think I've gotten the height to work in a flexbox.

from iron-data-table.

Saulis avatar Saulis commented on August 28, 2024

Decided to add the default height back since some height is needed to make the table visible, either by explicit height or using flex height. For new users this might not be obvious.

from iron-data-table.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.