Giter VIP home page Giter VIP logo

Comments (7)

nicollite avatar nicollite commented on June 19, 2024 1

I think the error happend because FakeFirestore does't have the following fields implemented: FieldValue, arrayUnion, arrayRemove, increment, delete and FieldValue.serverTimestamp.
So when jest overides firestore this fields don't exists in FakeFirestore so the error is that FieldValue is undefined so it doesn't has serverTimestamp

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on June 19, 2024 1

Turns out that classes need the new keyword. We cannot use new firestore(), as the canonical syntax does not support this.

Solution: declare the firestore property as a named function, and set a static method inside its body! Like so:

firestore: function firestoreConstructor() {
  firestoreConstructor.FieldValue = FakeFirestore.FieldValue;  // The magic sauce
  return new FakeFirestore(overrides.database);
},

That seems to work in my testing, and Travis CI agrees. 😁

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on June 19, 2024

I've tried importing "firebase-admin" before "firestore-jest-mock" and calling mockFirebase, and set FieldValue on the new firestore instance, but that doesn't work at all the way I'd hoped it would 😅

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on June 19, 2024

To note how I use FieldValue, I use its arrayUnion, arrayRemove, increment, delete, and serverTimestamp functions. As for testing, I'm okay just checking the mock that they were called, since my code doesn't (or I suppose shouldn't) rely on or confirm updates made to the database in the same function.

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on June 19, 2024

I would love to start a PR and work on this myself, but I cannot seem to figure out how to get my Node package to install local packages. (I mean, it installs just fine and points to the right file, but my tests behave as though no mock was made, whereas when I use your package by name and version, the above behavior occurs to indicate that the mock was successful).

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on June 19, 2024

Okay, I've got an implementation that tests well so far. PR soon.

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on June 19, 2024

A bit of an issue in the firestore stub. If I'm reading it right, the firebase.firestore mock is implemented this way:

firestore() {
  return new FakeFirestore(overrides.database);
},

The canonical firestore.FieldValue is defined statically on the firestore type. I'm having a hard time finding examples online, but I'm not sure that JavaScript functions can have static properties defined on them.

I'm not finding many answers readily online. Would something like the following work?

firestore: class extends FakeFirestore {
  constructor() {
    super(overrides.database);
  }
},

The idea is to expose both the constructor and static methods, so would this work if I have the FieldValue class defined as a static property of FakeFirestore?

from firestore-jest-mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.