Giter VIP home page Giter VIP logo

Comments (7)

AverageHelper avatar AverageHelper commented on July 18, 2024 2

@sbatson5 Document and Collection path fixes are on #102.

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on July 18, 2024 1

I'm working on a branch that will make the path property of firestore-jest-mock's document and collection references match more closely Firestore's analagous path properties. Ours are close (except in the case of collectionGroup queries), but not quite ready to assert document paths correctly. It may be prudent to wait on exporting this function until our paths are more consistent, so as to avoid breaking things in the future.

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on July 18, 2024 1

I'm working on a branch ...

Update on that branch. It's very nearly ready. For the sake of my own dependent projects, I'm waiting on firestore-jest-mock's TypeScript definitions before I get that work merged in.

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on July 18, 2024

We've been using this matcher in our own production code for some time, and have found it extremely handy. I don't know how to export Jest matchers from a package, but it must be possible with minimal work on users' end, considering jest-extended is a thing.

from firestore-jest-mock.

sbatson5 avatar sbatson5 commented on July 18, 2024

Sorry it's taken me so long to read through this but I like the concept a lot. And it doesn't make our API more complicated.

I'm not finding an easy way for us to have this automatically added to jest, but it looks like we can follow what they do on this library:
https://github.com/tanem/jest-prettyhtml-matchers#basic-usage

The end-user can just call expect.extend(toHaveFirestorePath) if they want to use the helper. That doesn't feel like a big ask, given the value it adds. So we would just export this as a helper from our package. What do you think?

from firestore-jest-mock.

AverageHelper avatar AverageHelper commented on July 18, 2024

Absolutely! It would be simple to write up a function to export. Perhaps we would even export a function that would build toHaveFirestorePath and whatever matchers we want to add in the future. expect.extend takes an object of functions keyed by the name that Jest should expose on the expect helper, so having some function that returns { toHaveFirestorePath } would be perfect.

from firestore-jest-mock.

sbatson5 avatar sbatson5 commented on July 18, 2024

Looking at that today!

from firestore-jest-mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.